Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Add multiline query support #131224

Merged
merged 27 commits into from
May 19, 2022
Merged

[Osquery] Add multiline query support #131224

merged 27 commits into from
May 19, 2022

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Apr 29, 2022 •
edited
Loading

Summary

Add multi-line support for Osquery editor.

[ ✓ ] - Osquery editor displays and uses multi line query
[ ✓ ] - Osquery Manager instance pack config shows single line query
[ ✓ ] - Refactored Pack's Saved queries table to be always single line, truncate values, separate columns and added tooltip
[ ✓ ] - Unit tests of converter
[ ✓ ] - API integration tests

Zrzut ekranu 2022-04-29 o 13 12 43

Zrzut ekranu 2022-05-16 o 08 23 32

Zrzut ekranu 2022-05-18 o 16 59 55

Zrzut ekranu 2022-05-6 o 13 16 03

@tomsonpl tomsonpl added release_note:enhancement enhancement New value added to drive a business result Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature v8.3.0 labels Apr 29, 2022
@tomsonpl tomsonpl self-assigned this Apr 29, 2022
@tomsonpl tomsonpl marked this pull request as ready for review April 29, 2022 15:03
@tomsonpl tomsonpl requested a review from a team as a code owner April 29, 2022 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@tomsonpl
Copy link
Contributor Author

tomsonpl commented May 2, 2022

@elasticmachine merge upstream

@tomsonpl tomsonpl requested a review from patrykkopycinski May 4, 2022 07:33
@tomsonpl
Copy link
Contributor Author

tomsonpl commented May 4, 2022

@elasticmachine merge upstream

@tomsonpl
Copy link
Contributor Author

tomsonpl commented May 8, 2022

@elasticmachine merge upstream

@tomsonpl
Copy link
Contributor Author

@elasticmachine merge upstream

@tomsonpl
Copy link
Contributor Author

@elasticmachine merge upstream

@tomsonpl
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

tomsonpl added 3 commits May 18, 2022 16:38
@tomsonpl
Merge branch 'main' into osquery-multi-line
637bc9d 
# Conflicts:
#	x-pack/plugins/osquery/public/packs/queries/ecs_mapping_editor_field.tsx
@tomsonpl
remove old file
268d54a
@tomsonpl
fix typo
b47286a
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 263 264 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB +690.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 119 116 -3

Total ESLint disabled count

id before after diff
osquery 124 121 -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

patrykkopycinski
patrykkopycinski approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @tomsonpl 💪

@tomsonpl tomsonpl merged commit 5ecde4b into elastic:main May 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 19, 2022
@spalger spalger mentioned this pull request May 31, 2022
Open
@nastasha-solomon nastasha-solomon mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@tomsonpl tomsonpl

Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Osquery Security Solution Osquery feature release_note:enhancement Team:Asset Management Security Asset Management Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomsonpl @elasticmachine @kibanamachine @kibana-ci @patrykkopycinski